Add @ember/string v4 to peerDependencies #9511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
|
@SergeAstapov thanks! bit of an odd case considering is an optional (and deprecated) dep. I'd note it's only present because peers need to be re-declared at each level, and its ember-inflector (an optional but deprecated dep) that is actually the optional peer here. You'll want to make sure the range in ember-inflector matches. |
|
@runspired my assumption is that if it's optional and not present, then we are ok. but if it's present but v4 - then it's a trouble Thanks for lending this! |
wagenet
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@ember/string v4 was recently published https://github.com/emberjs/ember-string/releases/tag/v4.0.0-%40ember%2Fstring
it's not possible to upgrade as
@ember-data/storestill requires v3.Notes for the release